Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress bar to saving project #725

Closed
wants to merge 2 commits into from

Conversation

Kaushik-Iyer
Copy link
Contributor

@Kaushik-Iyer Kaushik-Iyer commented Mar 16, 2024

Attempts to solve a part of #707

I don't know if this is the proper way or syntax to use the progress bar for this project, since this is the first time I am using it, but I have tested this locally and it seemed to work

@paulojamorim
Copy link
Collaborator

@Kaushik-Iyer

Thanks for the pull request. At this moment I cannot accept it because the interface code is together with the data code (project.py).

Please create a class inside gui/dialogs.py for the dialog. You can submit project information to dialogs class by pubsub.

@Kaushik-Iyer
Copy link
Contributor Author

Is this the correct way of implementing pubsub? I tested this locally, but my dialog box doesnt close by itself on save completion. I am having to manually click 'Close' button. What am I doing wrong here?
Screenshot from 2024-04-01 17-43-54

@vhosouza
Copy link
Member

Thanks, @Kaushik-Iyer. The progress bar for saving files has been added at PR #735.

@vhosouza vhosouza closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants